-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a more complete Custom Instrumentation documentation #9952
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-performance for triage ⏲️ |
@pbernery thanks for raising this! That's frustrating, sorry about the time waster—we'll take a look at fixing the error you found, and expanding the docs As for attaching to the current scope, are you adding instrumentation in a threaded environment? |
Hey @gggritso. |
transferring this to docs, will update the custom instrumentation sample. |
Assigning to @getsentry/support for routing ⏲️ |
I understand the limitations. I proposed some things here getsentry/sentry-ruby#2307, but still that would depend on the server. Maybe the server could return a status code directly when such content is posted? And thus the client could informed the developer. |
Problem Statement
The https://docs.sentry.io/platforms/ruby/performance/instrumentation/custom-instrumentation/ documentation explains how to track custom transactions. However, it is not complete, calling
start_transaction
won't be enough, it has to be attached to the current scope.One correct way to implement custom can be found in the Sentry client code, for instance https://github.com/getsentry/sentry-ruby/blob/6cdb1fc3b1a7f2f10f2783ba27010522d9bf0af5/sentry-rails/lib/sentry/rails/action_cable.rb, where we can see a creation of a scope, then a transaction, and several other things.
I spent many hours understanding why the sample provided in the first documentation did not show up on the Sentry front. I believe the documentation needs to be more complete.
This documentation should also inform about the limit of spans, which can be found on the SDK creation documentation https://develop.sentry.dev/sdk/performance/#maxspans, but is not mentioned on the client documentation.
Solution Brainstorm
No response
Product Area
Performance
The text was updated successfully, but these errors were encountered: