Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of build warnings: Double-quoted include "SentryAttachment.h" in framework header, expected angle-bracketed instead #3972

Open
matthewreimer opened this issue May 13, 2024 · 3 comments

Comments

@matthewreimer
Copy link

Platform

iOS

Environment

Production, Develop, TestFlight, Other

Installed

Swift Package Manager

Version

8.25.0

Did it work on previous versions?

8.21.0

Steps to Reproduce

Build an app that's using Sentry SDK via SPM. This might be the same issue as one you've fixed before in #1072.

Expected Result

No build warnings

Actual Result

Double-quoted include "SentryAttachment.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryBreadcrumb.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryClient.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryCrashExceptionApplication.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDebugImageProvider.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDebugMeta.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDsn.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryEnvelopeItemHeader.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryError.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryEvent.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryException.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryFrame.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryGeo.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryHttpStatusCodeRange.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryHub.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanProtocol.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanContext.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySampleDecision.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanStatus.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryMeasurementUnit.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryMechanism.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryMechanismMeta.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryMessage.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryNSError.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryOptions.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryProfilingConditionals.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryRequest.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySDK.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySampleDecision.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySamplingContext.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryScope.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanProtocol.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanContext.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanId.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanProtocol.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanStatus.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryStacktrace.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryThread.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryTraceHeader.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySampleDecision.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryTransactionContext.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySampleDecision.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySpanContext.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryUser.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryUserFeedback.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentryDefines.h" in framework header, expected angle-bracketed instead
Double-quoted include "SentrySerializable.h" in framework header, expected angle-bracketed instead

Are you willing to submit a PR?

Maybe

@philipphofmann
Copy link
Member

@matthewreimer, which Xcode version are you using?

@matthewreimer
Copy link
Author

@philipphofmann Version 15.3 (15E204a).

@matthewreimer
Copy link
Author

matthewreimer commented May 14, 2024

@philipphofmann I just tried 15.4 (15F31d) and I get the same warnings. I'm using SentrySwiftUI if that matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Needs More Information
Development

No branches or pull requests

3 participants