-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to send metrics via sentry-cli #2001
Comments
@jan-auer Is metrics rate limiting going to be relevant for the CLI, given that each send-metrics call will originate from a separate CLI call with the proposed API? If so, I think we will need to implement this change by somehow saving the backoff information in a temp file |
After discussing with @szokeasaurusrex, code location will not be implemented (at least not for the initial iteration). |
Add CLI command that can emit metrics. Fixes GH-2001
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command that can emit metrics. Fixes GH-2001
Add CLI command send-metric for emitting metrics to Sentry. Add new command-parser that uses clap's Derive API. Future commands should use this as the Derive API makes it: -Easier to read, write, and modify arguments and commands. -Easier to keep the argument declaration and reading of argument in sync. -Easier to reuse shared arguments. Fixes GH-2001
Nice work @elramen! Looking forward to this 😄 |
Using
sentry-cli
is a nice way to send metrics in bash scripts and similar.We already have support for sending events, so this seems like a nice fit.
Ideal API:
send-metric
: Command to send metric. Requires argument ofincrement
,distribution
,set
, orgauge
(matches with our sdk public API).Options:
-n
: Name of metric (required)-v
: Metric value (required)-u
: unit (optional)-t
: tag (optional, can provide multiple)maybe we can also somehow capture code location?
--
Since these needs have evolved over the last couple of weeks, please also make sure to implement:
The most recent state of current Metrics features can be found in [this doc], please check it once you plan to start the implementation of this issue, to see if there is anything else that needs to be implemented. (https://docs.google.com/spreadsheets/d/14cjYBAWI6RkDilqXYAsLYa89wIWdQJq350fjwqT1uyI/edit#gid=0)
The text was updated successfully, but these errors were encountered: