Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we really open tempfile with truncate(false)? #1989

Closed
szokeasaurusrex opened this issue Mar 25, 2024 · 1 comment · Fixed by #2073
Closed

Should we really open tempfile with truncate(false)? #1989

szokeasaurusrex opened this issue Mar 25, 2024 · 1 comment · Fixed by #2073
Assignees

Comments

@szokeasaurusrex
Copy link
Member

We had to add .truncate(false) to our tempfile opening code in #1988 to fix a new Clippy lint. .truncate(false) is equivalent to the previous behavior, but it seems like it would make more sense to use truncate(true). However, when I tried truncate(true), some tests failed.

Perhaps, we should be using truncate(true), and we in fact have a bug here.

@szokeasaurusrex
Copy link
Member Author

After investigating, I determined that truncate(false) provides the desired behavior, after all. I will prepare a PR to add comments to document why this is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant