-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we really open tempfile with truncate(false)
?
#1989
Labels
Comments
After investigating, I determined that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We had to add
.truncate(false)
to our tempfile opening code in #1988 to fix a new Clippy lint..truncate(false)
is equivalent to the previous behavior, but it seems like it would make more sense to usetruncate(true)
. However, when I triedtruncate(true)
, some tests failed.Perhaps, we should be using
truncate(true)
, and we in fact have a bug here.The text was updated successfully, but these errors were encountered: