-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sourcemaps upload
: Create new release if release does not exist yet
#1982
Labels
Comments
szokeasaurusrex
changed the title
Mar 13, 2024
sourcemaps upload
: Create new release if release does not exit yetsourcemaps upload
: Create new release if release does not exist yet
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The scenario
Suppose a user runs
sourcemaps upload
against a directoryfoobar/
where the JS source files have already been injected with debug IDs. Like so:Suppose further that the release
1.2.3
does not exist yet.Current behavior
The user will observe that their artifact bundle has been uploaded to Sentry. The artifact bundle is linked to release
1.2.3
, but when the user clicks the link to the release, they discover that release1.2.3
does not exist, because the command does not create the release.Suggested improved behavior
If the user passes a non-existing release, such as in the above example, we should implicitly create the release for them. The CLI should also output a message, such as the following, to indicate that the release was created:
Implementation notes
The functionality for implicitly creating the release should be implemented server-side, i.e. in getsentry/sentry. We need to modify this code, or the method called by the code. We should indicate in the response whether we created a release in the response.
Only after implementing the functionality in Sentry can we implement the message in the CLI to indicate whether the release was created, based on the response from the server.
The text was updated successfully, but these errors were encountered: