-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce upload_files_parallel
API calls
#1981
Labels
Comments
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
upload_files_parallel
, we make an API call at the beginning of the method to obtain a list of existing files, then if we find we have a new file to upload, which would replace the existing one, we delete the existing file with a separate API call, and lastly, we upload the new file, also with a separate API call.It appears this logic is designed to allow us to overwrite files that already exist on the server. We should instead perform this logic on the server, and remove this logic from the CLI. Having the logic on the CLI makes the system prone to race conditions, and slows uploads by adding unnecessary API calls.
The text was updated successfully, but these errors were encountered: