Skip to content

Commit 0295c36

Browse files
authored
fix(commands): Add missing env vars for release name detection (#2051)
Check env vars SENTRY_RELEASE and GAE_DEPLOYMENT_ID when detecting release name, as done by SDKs. Fixes GH-2050
1 parent 554f4fc commit 0295c36

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

src/utils/releases.rs

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,14 @@ pub fn infer_gradle_release_name(path: Option<PathBuf>) -> Result<Option<String>
8585

8686
/// Detects the release name for the current working directory.
8787
pub fn detect_release_name() -> Result<String> {
88-
// cordova release detection first.
88+
// try SENTRY_RELEASE environment variable
89+
if let Ok(release) = env::var("SENTRY_RELEASE") {
90+
if !release.is_empty() {
91+
return Ok(release);
92+
}
93+
}
94+
95+
// try cordova release detection
8996
if let Some(release) = get_cordova_release_name(None)? {
9097
return Ok(release);
9198
}
@@ -142,6 +149,13 @@ pub fn detect_release_name() -> Result<String> {
142149
return Ok(release);
143150
}
144151

152+
// try Google App Engine: https://cloud.google.com/appengine/docs/standard/python3/runtime#environment_variables
153+
if let Ok(release) = env::var("GAE_DEPLOYMENT_ID") {
154+
if !release.is_empty() {
155+
return Ok(release);
156+
}
157+
}
158+
145159
match vcs::find_head() {
146160
Ok(head) => Ok(head),
147161
Err(e) => Err(anyhow!(

0 commit comments

Comments
 (0)