Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen IP address scrubbing in span.domain tag #3572

Open
gggritso opened this issue May 9, 2024 · 2 comments
Open

Loosen IP address scrubbing in span.domain tag #3572

gggritso opened this issue May 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@gggritso
Copy link
Member

gggritso commented May 9, 2024

Problem Statement

IP addresses like 8.8.8.8 get fully scrubbed out to *.*.*.*. When users look at the requests module, all requests to IP addresses get mashed together.

Solution Brainstorm

  • no scrubbing at all (IPv4 addresses have a known cardinality. It's only 4 billion! That's fine, right? I'm kidding)
  • partial scrubbing (e.g., 8.8.8.8 becomes *.*.8.8 or *.*.*.8 or 8.8.*.*)
  • customizable IP scrubbing allowlist (let people add IPs that don't get scrubbed)
  • allow self-hosted users to turn IP scrubbing off (people who have their own infra might want to turn this off, and bear the weight of high cardinality)

Product Area

Ingestion and Filtering

@gggritso gggritso changed the title Loosen IP address scrubbing in Requests module Loosen IP address scrubbing in span.domain tag May 9, 2024
@gggritso gggritso transferred this issue from getsentry/sentry May 9, 2024
@gggritso gggritso added the enhancement New feature or request label May 9, 2024
@jjbayer
Copy link
Member

jjbayer commented May 10, 2024

customizable IP scrubbing allowlist (let people add IPs that don't get scrubbed)

I wonder if we could get to an "80%" solution by hardcoding a list of"special" IPs. E.g. reserved IPs, DNS servers, .... Unless this does not cover the majority of the cases.

@aldy505
Copy link

aldy505 commented May 11, 2024

I'd like to see private IPs being not redacted on SaaS and self-hosted. For public IPs, I think it's better if it's redacted on SaaS and not redacted on self-hosted. Since on self-hosted, it's a different environment, it's only possible that the outgoing request is made only for those defined on the tracePropagationTargets config (from the sdk side).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

4 participants