feat(metrics): Forward received_at field to Kafka #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
commented
May 10, 2024
| @@ -725,6 +725,7 @@ def send_buckets(buckets): | |||
| produced_buckets.sort(key=lambda b: (b["name"], b["value"])) | |||
| for bucket in produced_buckets: | |||
| del bucket["timestamp"] | |||
| del bucket["received_at"] | |||
There was a problem hiding this comment.
This test was very tricky to update, we might want to follow up with a PR to fix timestamps across all of our tests.
jjbayer
approved these changes
May 10, 2024
Dav1dde
reviewed
May 10, 2024
|
|
||
|
|
||
| class _WithinBounds: | ||
|
|
There was a problem hiding this comment.
Surprised the formatter doesn't complain about this newline
| return f"{self._lower_bound} <= x <= {self._upper_bound}" | ||
|
|
||
|
|
||
| def time_after(lower_bound): |
There was a problem hiding this comment.
This doesn't assert after, but after until now. I think making the upper bound on time_within optional and defaulting to now is fine.
There was a problem hiding this comment.
Yeah, I was indeed thinking about a better name.
| @@ -1873,3 +1890,48 @@ def test_metrics_with_denied_names( | |||
| assert volume_metric["tags"]["outcome.reason"] == "denied-name" | |||
|
|
|||
| assert "d:custom/memory_usage@byte" in metrics | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("mode", ["default", "chain"]) | |||
| @@ -725,6 +725,7 @@ def send_buckets(buckets): | |||
| produced_buckets.sort(key=lambda b: (b["name"], b["value"])) | |||
| for bucket in produced_buckets: | |||
| del bucket["timestamp"] | |||
| del bucket["received_at"] | |||
Co-authored-by: David Herberth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards the
received_atfield ofBucketMetadatato Kafka. An important thing to notice is that the current Kafka schema allows additional fields: https://github.com/getsentry/sentry-kafka-schemas/blob/main/schemas/ingest-metrics.v1.schema.json meaning that this PR could be deployed without any side effects on the schemas, however, it would be best to mark the field as optional in the Kafka schema itself.The PR also introduces new facilities to relax timestamp assertions which are generally flaky.
Closes: #3515