Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what's wrong with cffi's setuptools support #3

Closed
ionelmc opened this issue Nov 17, 2017 · 6 comments
Closed

Clarify what's wrong with cffi's setuptools support #3

ionelmc opened this issue Nov 17, 2017 · 6 comments

Comments

@ionelmc
Copy link

ionelmc commented Nov 17, 2017

In the readme it say "CFFI's setuptools support alone does not properly work with wheels" - but what does that exactly mean? Some examples and clarifications would help a lot.

@mitsuhiko
Copy link
Member

I think this is left as an exercise for the reader :)

@ionelmc
Copy link
Author

ionelmc commented Dec 7, 2017

Come on @mitsuhiko this is really low effort response :) Surely you can string a sentence about what problems you had building wheels.

@mitsuhiko
Copy link
Member

f22df90

@ionelmc
Copy link
Author

ionelmc commented Dec 7, 2017

@mitsuhiko Well, better but still not 100% clear. But now looking over the code it looks like milkshake only adds the possibility of forcing universal wheels - so that's the problem with tags right?

Also, worth mentioning that milkshake is designed to use cffi in ABI out-of-line mode (and generates the cffi boilerplate for you)?

@mitsuhiko
Copy link
Member

Milksnake does a bunch of things, mostly related to invoking build tools and bundling resources.

@ionelmc
Copy link
Author

ionelmc commented Dec 7, 2017

Ah yes, not the best wording, I meant „regarding the cffi setuptools support, only adds ...”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants