added passing client_tags option to Trino plugin (#7633)

* added cleint_tags

added the option to pass client tags to trino clusters source

* removed redundant checks

* removed redundant test and fixed if condition

---------

Co-authored-by: Tsuneo Yoshioka <yoshiokatsuneo@gmail.com>

Author: RoeyoOgen

redash/query_runner/trino.py

@@ -59,6 +59,7 @@ def configuration_schema(cls):
                 "username": {"type": "string"},
                 "password": {"type": "string"},
                 "source": {"type": "string", "default": "redash"},
+                "client_tags": {"type": "string", "title": "Client tags (comma separated)"},
                 "catalog": {"type": "string"},
                 "schema": {"type": "string"},
                 "impersonation": {"type": "boolean", "default": False},
@@ -76,13 +77,15 @@ def configuration_schema(cls):
                 "username",
                 "password",
                 "source",
+                "client_tags",
                 "catalog",
                 "schema",
                 "impersonation",
             ],
             "required": ["host", "username"],
             "secret": ["password"],
             "extra_options": [
+                "client_tags",
                 "impersonation",
                 "impersonationField",
             ],
@@ -161,6 +164,13 @@ def _get_trino_user(self, user):
 
         return default_user
 
+    def _get_client_tags(self):
+        client_tags = self.configuration.get("client_tags")
+        if not client_tags:
+            return None
+        tags = [tag.strip() for tag in client_tags.split(",") if tag.strip()]
+        return tags or None
+
     def run_query(self, query, user):
         if self.configuration.get("password"):
             auth = trino.auth.BasicAuthentication(
@@ -177,6 +187,7 @@ def run_query(self, query, user):
             catalog=self.configuration.get("catalog", ""),
             schema=self.configuration.get("schema", ""),
             user=self._get_trino_user(user),
+            client_tags=self._get_client_tags(),
             auth=auth,
         )
 

tests/query_runner/test_trino.py

@@ -58,3 +58,11 @@ def test__get_catalogs(self, mock_run_query):
         catalogs = runner._get_catalogs()
         expected_catalogs = [TestTrino.catalog_name]
         self.assertEqual(catalogs, expected_catalogs)
+
+    def test_get_client_tags_parses_comma_separated_values(self):
+        runner = Trino({"client_tags": "finance,  redash  , ,analytics"})
+        self.assertEqual(runner._get_client_tags(), ["finance", "redash", "analytics"])
+
+    def test_get_client_tags_returns_none_when_empty(self):
+        runner = Trino({"client_tags": " ,  , "})
+        self.assertIsNone(runner._get_client_tags())