test/nginx/request(): use WHATWG Responses (#2045)

Simplifies test `request()` implementation to use standard `Response` classes.  The `request()` function aims to be as similar to `fetch()` as possible, while allowing for non-standard behaviour necessary for tests.  Not using `Response` was an oversight in the initial implementation.

Author: alxndrsn

test/nginx/src/mocha/mocha.setup.js

@@ -0,0 +1,16 @@
+const http = require('node:http');
+const https = require('node:https');
+
+const log = (...args) => console.log('[mocha-setup]', ...args);
+
+module.exports = {
+  mochaHooks: {
+    afterAll() {
+      log('Cleaning up HTTP(S) Response objects whose bodies have not been read...');
+      http.globalAgent.destroy();
+      https.globalAgent.destroy();
+
+      log('Cleanup complete.');
+    },
+  },
+};

test/nginx/src/mocha/request.js

@@ -1,5 +1,4 @@
 const { isIPv6 } = require('node:net');
-const { Readable } = require('node:stream');
 
 module.exports = request;
 
@@ -16,29 +15,11 @@ function request(url, { body, ...options }={}) {
       const req = getProtocolImplFrom(url).request({ ...options, ...preserve(url) }, res => {
         res.on('error', reject);
 
-        const body = new Readable({ read:() => {} });
-        res.on('error', err => body.destroy(err));
-        res.on('data', data => body.push(data));
-        res.on('end', () => body.push(null));
-
-        const text = () => new Promise((resolve, reject) => {
-          const chunks = [];
-          body.on('error', reject);
-          body.on('data', data => chunks.push(data));
-          body.on('end', () => resolve(Buffer.concat(chunks).toString('utf8')));
-        });
-
-        const status = res.statusCode;
-
-        resolve({
-          status,
-          ok: status >= 200 && status < 300,
-          statusText: res.statusText,
-          body,
-          text,
-          json: async () => JSON.parse(await text()),
+        resolve(new Response(res, {
+          status: res.statusCode,
+          statusText: res.statusMessage,
           headers: new Headers(res.headers),
-        });
+        }));
       });
       req.on('error', reject);
       if(body !== undefined) req.write(body);

test/package.json

@@ -4,7 +4,7 @@
     "lint": "ESLINT_USE_FLAT_CONFIG=false npx eslint --cache .",
     "test:github-actions": "mocha ./github-actions.spec.js",
     "test:nginx": "npm run test:nginx:mocha && npm run test:nginx:playwright",
-    "test:nginx:mocha": "NODE_TLS_REJECT_UNAUTHORIZED=0 mocha ./nginx/src/mocha",
+    "test:nginx:mocha": "NODE_TLS_REJECT_UNAUTHORIZED=0 mocha './nginx/src/mocha/**/*.spec.js' --require ./nginx/src/mocha/mocha.setup.js",
     "test:nginx:playwright": "NODE_TLS_REJECT_UNAUTHORIZED=0 playwright test",
     "test:service": "mocha ./service.spec.js",
     "test": "npm run lint && npm run test:github-actions && npm run test:nginx && npm run test:service"