You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Crash on attempted cancel of pull from Central server when offline
Steps to reproduce the problem
Open Briefcase, get a form list from a Central server
Go offline
Initiate pull, see it hang. Cancel pull, see crash.
Expected behavior
It should be possible to cancel a pull even when offline.
Other information
There's an NPE in PullPanel's onCancel handler when pullJobRunner is null. I think Central.pull is never returning in that scenario. If we try to only cancel if pullJobRunner is non-null, then we end up with the job resuming once connectivity is established and the button having the wrong state.
This works fine with an Aggregate server.
The text was updated successfully, but these errors were encountered:
Software versions
Briefcase v1.17.4
Problem description
Crash on attempted cancel of pull from Central server when offline
Steps to reproduce the problem
Expected behavior
It should be possible to cancel a pull even when offline.
Other information
There's an NPE in
PullPanel
'sonCancel
handler whenpullJobRunner
isnull
. I thinkCentral.pull
is never returning in that scenario. If we try to onlycancel
ifpullJobRunner
is non-null, then we end up with the job resuming once connectivity is established and the button having the wrong state.This works fine with an Aggregate server.
The text was updated successfully, but these errors were encountered: