Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalisation -- Help with Spanish #212

Open
CRomano31415 opened this issue Oct 3, 2018 · 27 comments
Open

Internationalisation -- Help with Spanish #212

CRomano31415 opened this issue Oct 3, 2018 · 27 comments
Labels
help wanted 🙏 This could use your insight or help

Comments

@CRomano31415
Copy link

This issue stems from the Inernationalisation issue #202

Currently working on:

  • Gathering list of words in Spanish, to be placed in sp-json file, get one started so we can modify!

Current challenges:

  • how to tag lists of words as there is considerable difference in meaning based on geographical areas, ideas?
@wooorm
Copy link
Member

wooorm commented Oct 3, 2018

@CRomano31415 Nice! 🎉

Gathering list of words in Spanish, to be placed in sp-json file, get one started so we can modify!

Push early so people can help 👍

how to tag lists of words as there is considerable difference in meaning based on geographical areas, ideas?

Depends, are you working on profanities or equality?

@CRomano31415
Copy link
Author

Profanities.

If anyone else can push before me, go for it - currently at work and won't be able to push for a few hours.

@wooorm wooorm added help wanted 🙏 This could use your insight or help hacktoberfest labels Oct 3, 2018
@wooorm
Copy link
Member

wooorm commented Oct 3, 2018

In case of profanities, maybe there’s some lists like this already out there!

@baezor
Copy link

baezor commented Oct 4, 2018

Which is the status? How can I help? @CRomano31415

@CRomano31415
Copy link
Author

I've found some lists in discussion boards, there are no official ones that I have been able to find. But you can start putting it together.

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 4, 2018

Que paso? Se habla espanol! Puedo ayudar.

What's up? I know how to speak Spanish. I can help. I know a few inappropriate Spanish words and can contribute. Is it in the sp-json file?

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 4, 2018

@CRomano31415 - I think the international 2 character code for Spanish is es, not sp. Do you think the file should be named es-json instead?

http://www.loc.gov/standards/iso639-2/php/code_list.php

@CRomano31415
Copy link
Author

@MrBenJ Sounds good, do you want to start it? I have a huge list of words that I'm cleaning up but wasn't sure how to code them since some are not profane in some countries, but then I realized if it's profane to some, it should be flagged as profane so I'm almost done cleaning up. If you upload a json, I can add to it. I was looking at fr-json and I wasn't sure what the numbers next to the words were, do you know?

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 4, 2018

@CRomano31415 - Sure thing. I'd be happy to start it off.

Where are you finding es-json or fr-json ? I'm new to this project and don't know where these files are. Let me know and I'll get started right away :)

@CRomano31415
Copy link
Author

Well, that is a great question, because I could have sworn I saw fr-json not too long ago in one of the remarks... This issue points to it, but now I can't find it either.

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 4, 2018

Ahh! It looks like that PR hasn't been merged into words/cuss yet. Looking at what @wooorm has commented with on the issue you're referencing, I'll go ahead and follow the same naming conventions they're asking for of the other contributor. We can work on this PR together and get this moving :). Happy Hacktoberfest!

@CRomano31415
Copy link
Author

CRomano31415 commented Oct 4, 2018

Ok @MrBenJ here's the list We need help with ppl picking the profane terms (not all of them belong in profanity - some may belong elsewhere) and adding them to a json (in the right location - not sure where that is at).

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 4, 2018

Hey @CRomano31415 - I wrote a little script to JSONify your list and added a couple of words that weren't on there. I made a pull request to your own repo here:

CRomano31415/SpanishProfanity#1

In the comments, I mentioned that I set everything to a value of 2 for the time being.

My coworker @fportela-ns actually helped out a little bit with some insults that were missing as well.

@CRomano31415
Copy link
Author

Awesome!! I have no idea where to put that JSON file here, maybe @wooorm can guide us? Titus, we have a JSON file with spanish profanity, which repo do we add it to?

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 4, 2018

Hey @CRomano31415 - My coworker @fportela-ns wants to help out and he's a native Spanish speaker. We found a few words in there that don't quite belong chancla is similar to sandal and aguacates is @fportela-ns 's favorite food. He's gonna fork that repo and start working on it

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 4, 2018

Also, as a fun side note, how many times in one's life can you say, "I have a file with Spanish profanity! Where do I put it!?" I'm giggling over here.

@CRomano31415
Copy link
Author

I feel pretty good that my contribution to society today has been a list of profane words.
Yes, please @fportela-ns pull and fix. To be transparent, I just kind of scraped the web and cleaned it up LOL I didn't quite invest the time in modifying it. And also some words have different meaning in different countries so...idk what to do about those...

@fportela-ns
Copy link

fportela-ns commented Oct 5, 2018

hey @CRomano31415 have the PR ready 😄 honestly there are a LOT of words that I've no idea what they mean haha. But here's my contribution CRomano31415/SpanishProfanity#2.

I just removed a few words that I consider can't be profane in any way, and marked as 1 words that are profane but only depending on the context

wooorm pushed a commit that referenced this issue Oct 5, 2018
Related-to GH-195.
Related-to GH-212.

Closes GH-217.

Reviewed-by: Titus Wormer <[email protected]>
@wooorm
Copy link
Member

wooorm commented Oct 5, 2018

@fportela-ns You mean @CRomano31415 I think 😉

This looks like a really good start! Awesome work all!
How do you all want to proceed? How can I help?

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 6, 2018

@fportela-ns @wooorm @CRomano31415

I think the next best course of action is to grab @CRomano31415 's file and make a proper pull request to this repo: https://github.com/words/cuss

I've already submitted a PR to get-alex/alex and I'd like @CRomano31415 and @fportela-ns to get some credit for contributing to this project, so I'll let them go ahead and make the appropriate PR's to get credit/contribution/hacktoberfest points :).

@AhmedRedaAmin
Copy link

AhmedRedaAmin commented Oct 6, 2018

@MrBenJ Hey ! can you pass over the jsonify script you used on the list ? I will very much need it actually :'D
I am currently using Claudia's template and manually adding them to the json file seems incredibly ludicrous .

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 7, 2018

Hey @AhmedRedaAmin

Sure thing. I whipped up an NPM package for you as a CLI tool:
https://www.npmjs.com/package/wordlist-to-json

Here's the git repo if you feel like contributing :)
https://github.com/MrBenJ/wordlist-to-json

You can install it globally with:

npm install -g wordlist-to-json

And use it like this:

wordlist-to-json --file my_wordlist.txt --space 2

Hope you like it :)

@AhmedRedaAmin
Copy link

Thanks @MrBenJ , that is AWESOME !
I 'll definitely look into that repo as soon as I finish what's on my hands currently , that thing is a big help mate , thanks again .

@wooorm
Copy link
Member

wooorm commented Oct 13, 2018

Soo, we landed Spanish in cuss! Thanks @CRomano31415, @baezor, @MrBenJ, and @fportela-ns for working on this! 🎉

The next step is to add something for Spanish to retext-equality. Anyone able and interested to work on that?

@MrBenJ
Copy link
Contributor

MrBenJ commented Oct 15, 2018

Hey @wooorm - I have some time. I should be able to help out on retext-equality. Might not get to it today, but probably by the end of the week I can lend a hand.

@wooorm
Copy link
Member

wooorm commented Oct 17, 2018

@MrBenJ Awesome! And that’s fine, take your time! :)

@Leodau
Copy link

Leodau commented Oct 26, 2018

Hey all, just added some ES Venezuelan dialect profanities into cuss 👮

feat(Profanity_ES): Adding Venezuelan dialect profanities.

There is indeed a problem with all the ES profanity lists i find on the net, since ES is so geo sensitive, the only real way into solving this is actually trying to not add any word that could be used usually by public speakers, teachers, tv.. and that are correctly defined in the dictionary, even though they might be used by some dialect as profanities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted 🙏 This could use your insight or help
Development

No branches or pull requests

7 participants