-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
public_suffix() doesnt work with paths #54
Labels
Comments
It depends on what's the expected input. The documentation says "domains", although the argument is called https://github.com/schochastics/adaR/blob/8a8ec9f429d106a74243050d79c4801f2403f8ef/R/psl.R#L1 adaR::public_suffix(adaR::ada_get_hostname("http://google.de/test")) |
Actually, |
ok, for now I will adjust that in the docs so users are aware of that. good catch! |
schochastics
changed the title
public_suffix() doesn work with paths
public_suffix() doesnt work with paths
Sep 28, 2023
schochastics
added a commit
that referenced
this issue
Sep 28, 2023
schochastics
added a commit
that referenced
this issue
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
related to #51
Note that psl also fails.
need to reconsider if this is a bug or a feature
The text was updated successfully, but these errors were encountered: