Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public_suffix() doesnt work with paths #54

Open
schochastics opened this issue Sep 28, 2023 · 3 comments
Open

public_suffix() doesnt work with paths #54

schochastics opened this issue Sep 28, 2023 · 3 comments
Labels

Comments

@schochastics
Copy link
Member

adaR::public_suffix("http://google.de/test")
#> [1] NA

related to #51

Note that psl also fails.

psl::public_suffix("http://google.de/test")
#> [1] "de/test"

need to reconsider if this is a bug or a feature

@chainsawriot
Copy link
Collaborator

It depends on what's the expected input. The documentation says "domains", although the argument is called url.

https://github.com/schochastics/adaR/blob/8a8ec9f429d106a74243050d79c4801f2403f8ef/R/psl.R#L1

adaR::public_suffix(adaR::ada_get_hostname("http://google.de/test"))

@chainsawriot
Copy link
Collaborator

Actually, psl also expects "domains".

@schochastics
Copy link
Member Author

ok, for now I will adjust that in the docs so users are aware of that. good catch!

@schochastics schochastics changed the title public_suffix() doesn work with paths public_suffix() doesnt work with paths Sep 28, 2023
schochastics added a commit that referenced this issue Sep 28, 2023
schochastics added a commit that referenced this issue Sep 28, 2023
* fix #51

* more robust domain parsing

* better doc for public_suffix() #54
@schochastics schochastics pinned this issue Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants