Remove legacy attach implementation

Author: gesellix

client/src/main/groovy/de/gesellix/docker/client/container/ManageContainerClient.groovy

@@ -43,6 +43,10 @@ class ManageContainerClient implements ManageContainer {
   private final Logger log = LoggerFactory.getLogger(ManageContainerClient)
 
   private EngineApiClient client
+  /**
+   * @deprecated for removal
+   */
+  @Deprecated
   private EngineClient engineClient
   private DockerResponseHandler responseHandler
   private QueryParameterEncoder queryParameterEncoder
@@ -58,33 +62,6 @@ class ManageContainerClient implements ManageContainer {
     this.archiveUtil = new ArchiveUtil()
   }
 
-  /**
-   * @deprecated removed
-   * @see #attach(java.lang.String, java.lang.String, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, de.gesellix.docker.remote.api.core.StreamCallback, java.time.Duration)
-   */
-  @Deprecated
-  @Override
-  EngineResponse attach(String containerId, Map<String, Object> query, AttachConfig callback = null) {
-    log.info("docker attach")
-
-    // When using the TTY setting is enabled in POST /containers/create,
-    // the stream is the raw data from the process PTY and client’s stdin.
-    // When the TTY is disabled, then the stream is multiplexed to separate stdout and stderr.
-    EngineResponseContent<ContainerInspectResponse> container = inspectContainer(containerId)
-    boolean multiplexStreams = !container.content.config.tty
-
-    EngineResponse response = engineClient.post([
-        path            : "/containers/${containerId}/attach".toString(),
-        query           : query,
-        attach          : callback,
-        multiplexStreams: multiplexStreams])
-
-    if (!callback) {
-      response.stream.multiplexStreams = multiplexStreams
-    }
-    return response
-  }
-
   @Override
   void attach(String containerId, String detachKeys, Boolean logs, Boolean stream,
               Boolean stdin, Boolean stdout, Boolean stderr,

client/src/main/java/de/gesellix/docker/client/container/ManageContainer.java

@@ -2,7 +2,6 @@
 
 import de.gesellix.docker.client.EngineResponseContent;
 import de.gesellix.docker.engine.AttachConfig;
-import de.gesellix.docker.engine.EngineResponse;
 import de.gesellix.docker.remote.api.ContainerCreateRequest;
 import de.gesellix.docker.remote.api.ContainerCreateResponse;
 import de.gesellix.docker.remote.api.ContainerInspectResponse;
@@ -30,20 +29,6 @@
 
 public interface ManageContainer {
 
-  /**
-   * @deprecated removed
-   * @see #attach(java.lang.String, java.lang.String, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, de.gesellix.docker.remote.api.core.StreamCallback, java.time.Duration)
-   */
-  @Deprecated
-  EngineResponse attach(String container, Map<String, Object> query);
-
-  /**
-   * @deprecated removed
-   * @see #attach(java.lang.String, java.lang.String, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, java.lang.Boolean, de.gesellix.docker.remote.api.core.StreamCallback, java.time.Duration)
-   */
-  @Deprecated
-  EngineResponse attach(String container, Map<String, Object> query, AttachConfig callback);
-
   void attach(String containerId,
               String detachKeys,
               Boolean logs, Boolean stream,