Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessity of a Custom optimizer for the Critic (A2C). #19

Open
davinellulinvega opened this issue Jul 15, 2019 · 0 comments
Open

Necessity of a Custom optimizer for the Critic (A2C). #19

davinellulinvega opened this issue Jul 15, 2019 · 0 comments

Comments

@davinellulinvega
Copy link

Hello Germain / Everyone,

I am currently trying to implement the A2C algorithm as part of a simulation for my PhD. Given that, I have very limited time to do so, your source code is a great help, since the algorithm and operations are clearly outlined and not hidden away as is the case for OpenAI baseline implementation.
Still after having a look at the code in critic.py, I was wondering why did you define a custom optimizer for the critic has well (it is clearly justified for the actor), when simply compiling the critic network and passing MSE as the loss seem to have the same effect? Is there something I am missing here?
Anyway, that was just a though nothing game changing. Thanks a lot for sharing those implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant