Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markers are not printed correctly #10342

Closed
1 task done
tdipisa opened this issue May 17, 2024 · 0 comments · Fixed by #10395 · May be fixed by #10413
Closed
1 task done

Markers are not printed correctly #10342

tdipisa opened this issue May 17, 2024 · 0 comments · Fixed by #10395 · May be fixed by #10413
Assignees
@ElenaGallo @mahmoudadel54
Labels
bug Internal Print Regression
Milestone
2024.01.02

Comments

@tdipisa
Copy link
Member

tdipisa commented May 17, 2024 •
edited by allyoucanmap

Description

Markers are not printed well in 2024.01.00. There is a small regression here.

How to reproduce

Expected Result

The size and the position of the marker should be respected

Current Result

The marker is smaller and not correctly positioned in the printed map

markers_print.mp4

How to replicate without an existing map

print-annotation-issue.mp4
  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

Reviewer for this work is @allyoucanmap
@tdipisa tdipisa added this to the 2024.01.01 milestone May 17, 2024
@tdipisa tdipisa modified the milestones: 2024.01.01, 2024.02.00 May 17, 2024
@tdipisa tdipisa modified the milestones: 2024.02.00, 2024.01.01 May 20, 2024
@tdipisa tdipisa modified the milestones: 2024.01.01, 2024.01.02 May 28, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 3, 2024
@mahmoudadel54
geosolutions-it#10342: Markers are not printed correctly
b4daf41 
Description:
- fix issue of now shoing marker into print
@mahmoudadel54 mahmoudadel54 mentioned this issue Jun 3, 2024
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 3, 2024
@mahmoudadel54
geosolutions-it#10342: Markers are not printed correctly
83874cb 
Description:
- fix unit test
@tdipisa tdipisa linked a pull request Jun 3, 2024 that will close this issue
#10342: Fix issue of markers are not printed correctly #10395
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 6, 2024
@mahmoudadel54
geosolutions-it#10342: Markers are not printed correctly
3f0acd9 
Description:
- resolve review comments by creating 'getCachedImageById' function
- edit unit test
allyoucanmap pushed a commit that referenced this issue Jun 6, 2024
@mahmoudadel54
#10342: Fix issue of markers are not printed correctly (#10395)
bc4aefc
@ElenaGallo ElenaGallo self-assigned this Jun 6, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jun 7, 2024
@mahmoudadel54
geosolutions-it#10342: Fix issue of markers are not printed correctly (…
d73b022 
…geosolutions-it#10395)
@mahmoudadel54 mahmoudadel54 mentioned this issue Jun 7, 2024
Open
@mahmoudadel54 mahmoudadel54 linked a pull request Jun 7, 2024 that will close this issue
[Backport 2024.01.xx] - #10342: Fix issue of markers are not printed correctly (#10395) #10413
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
bug Internal Print Regression
Projects
None yet
Milestone
2024.01.02
4 participants
@tdipisa @allyoucanmap @ElenaGallo @mahmoudadel54