Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cache Options functionality extended to be applied on all the layers from a service #10281

Closed
10 tasks
ale-cristofori opened this issue May 6, 2024 · 0 comments · Fixed by #10349, #10361 or #10363
Closed
10 tasks

Comments

@ale-cristofori
Copy link
Contributor

ale-cristofori commented May 6, 2024

Description

The use cache options functionality that was created with this issue introduced the functionality to adapt the WMS integrated caching settings to custom scales, local projections and custom tile gridsets. The functionality has been introduced only layer-wide. Which means that is set on each single WMS imported layer manually and it is not activated by default, which means that the user has to manually go to set it up once the layer is loaded, if required.

recording_1.mp4

This new feature would allow to set the use cache option service-wide, which may mean that the tile grid setting and information window will be visible on the Catalog component rather than just on the TOC as it is now. (see below example)

Such setting would allow to introduce custom tile settings by default and have them automatically set for each layer imported in the map from a certain WMS tiled service.

Example below

Acceptance criteria

  • As a MapStore user who is able to set different tile caching options for a WMS tiled service I get onto the Catalog plugin and I will be able to find the use cache options button.
  • Clicking on the button that transforms the mode from standard to remote will allow extend the setting by default to all layers imported into the map from the selected WMS service.

Other useful information

At the moment we will just focus on WMS tiled services

ACs are:

  • add under ServerType a checkbox saying "use remote custom tile grids" (in all places where the catalog tool is used that means dashboards, viewer, context wizard step 2 and geostories)
    • this will have an info popover where it specifies "Make sure to have WMTS enabled in order to use custom tile grids"
    • this checkbox hides if "no vendor" is selected
  • when the checkbox is selected a new "remoteTileGrids" property is added to the service and to the layer in WMS.recordToLayer function
  • inside catalog epic addLayerAndDescribeEpic in here
    if (layer.type === 'wms') {
    there will be added the promise to retrieve tileGrids info and updating layer config, if remoteTileGrids is true and tiled is true should be the default value
  • tileGridStrategy will be forced to "custom"
  • tileGridCacheSupport and tileGrids are fetched from promise
  • test that saving map the service maintain the remoteTileGrids value and also that layer maintain this value in layer settings.

some hints can be found in here https://github.com/geosolutions-it/MapStore2/blob/master/web/client/components/TOC/fragments/settings/WMSCacheOptions.jsx#L333

Review to be assigned to @MV88

@ale-cristofori ale-cristofori changed the title Use Cache Options functionality extented to be service wide rather Use Cache Options functionality extended to be applied on all the layers from a service May 6, 2024
@MV88 MV88 self-assigned this May 6, 2024
@tdipisa tdipisa added this to the 2024.01.01 milestone May 14, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned MV88 May 14, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 22, 2024
… applied on all the layers from a service

Description:
- add the functionality for use cache options for mapviewer, dashboard, geostory, context
- add unit tests
- add translations
MV88 pushed a commit that referenced this issue May 23, 2024
… the layers from a service (#10349)

Description:
- add the functionality for use cache options for mapviewer, dashboard, geostory, context
- add unit tests
- add translations
@ElenaGallo ElenaGallo self-assigned this May 23, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 24, 2024
… applied on all the layers from a service

Description:
- handle a missing case of showing a warning message in case of not abling to fetch the grid sets
- add unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 27, 2024
… applied on all the layers from a service [resolve review comments]

Description:
- edit decription in unit test
- revert change in showing title of WMSCacheOptions changed by mistake
MV88 pushed a commit that referenced this issue May 27, 2024
… the layers from a service (#10361)

* #10281: Use Cache Options functionality extended to be applied on all the layers from a service
Description:
- handle a missing case of showing a warning message in case of not able to fetch the grid sets
- add unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 27, 2024
…ctionality extended to be applied on all the layers from a service (geosolutions-it#10349)
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 27, 2024
… applied on all the layers from a service (geosolutions-it#10361)

* geosolutions-it#10281: Use Cache Options functionality extended to be applied on all the layers from a service
Description:
- handle a missing case of showing a warning message in case of not able to fetch the grid sets
- add unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 27, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 27, 2024
MV88 pushed a commit that referenced this issue May 27, 2024
…ed to be applied on all the layers from a service (#10349, #10361) (#10363)

* fix conflicts in merging  #10281: Use Cache Options functionality extended to be applied on all the layers from a service (#10349)

* #10281: Use Cache Options functionality extended to be applied on all the layers from a service (#10361)

* #10281: Use Cache Options functionality extended to be applied on all the layers from a service
Description:
- handle a missing case of showing a warning message in case of not able to fetch the grid sets
- add unit tests

* fix FE unit test failure  #10281

* fix FE unit test failure  #10281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment