Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR merge policy #16

Open
frewsxcv opened this issue Sep 2, 2020 · 1 comment
Open

PR merge policy #16

frewsxcv opened this issue Sep 2, 2020 · 1 comment

Comments

@frewsxcv
Copy link
Member

frewsxcv commented Sep 2, 2020

Require review? What if nobody reviews?

@rmanoka
Copy link

rmanoka commented Sep 4, 2020

Expectation. Georust repos. should be constantly evolving: either add useful functionalities, or bugfixes; while also remaining a high-quality code base, and staying aligned to the short term or long term "agenda" declared for the repo.

With the above, I think an approving review from one of the "core maintainers / reviewers" is a must for PRs. The unfortunate side-effect — unresponsiveness to some issues / PRs — is a problem that plagues pretty much all open source repositories. Given the volunteer driven nature of the repos., I can't think of a good soln. for it. Just stating the obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants