Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of Error enum #197

Open
frewsxcv opened this issue Jul 4, 2022 · 3 comments
Open

Reduce size of Error enum #197

frewsxcv opened this issue Jul 4, 2022 · 3 comments

Comments

@frewsxcv
Copy link
Member

frewsxcv commented Jul 4, 2022

At the time of writing, the Error enum is 216 bytes. We can reduce the size by splitting the enum into different enums (e.g. DeserializeError, SerializeError, ToGeoError, etc). And also consider not embedding types like Feature (which is 208 bytes) into the enum fields (maybe).

@lnicola
Copy link
Member

lnicola commented Jul 4, 2022

We could also box the error details (but I assume clippy already suggests that).

@urschrei
Copy link
Member

urschrei commented Jul 4, 2022

Consider also #176 and #180

@rmanoka
Copy link
Contributor

rmanoka commented Jul 5, 2022

Error enum and serde_jso are at loggerheads. Iiuc, Serde json will expect all our semantic errors to be String s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants