Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate geo to gain algorithms #3

Open
RobWalt opened this issue Oct 29, 2023 · 2 comments
Open

Integrate geo to gain algorithms #3

RobWalt opened this issue Oct 29, 2023 · 2 comments

Comments

@RobWalt
Copy link
Collaborator

RobWalt commented Oct 29, 2023

While it's cool that the crate itself doesn't have many dependencies, we would potentially need to implement a lot of algorithms on our own if we stuck to only depending on geo-types. Also, this crate here is used:

  • as a debugging crate in many use cases anyways
  • used in conjunction with geo in many use cases anyways

Because of this, I think it's not a big issue if we depend on geo directly (with default features turned off!). I'm planning on implementing PolyLabel in geo which would be one of the cool algorithms we could utilize here then.

@urschrei
Copy link
Member

Is there any reason you can't pull in PolyLabel? I think the only dependency it doesn't share with geo is libc, and I can easily feature-gate that since it's only for FFI. I've wondered about integrating into geo before and decided that it was somewhat too specialised, so we wouldn't accept duplicate functionality.

@RobWalt
Copy link
Collaborator Author

RobWalt commented Oct 30, 2023

Oh I totally forgot to do the obvious thing first: searching on crates.io 😅

I found your repo and I'll just use it as suggested 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants