Skip to content

Commit fe24ecb

Browse files
authored
Merge pull request #365 from norkunas/cleanup-ci
Cleanup CI configuring composer's minimum-stability
2 parents e9d698b + 6da1047 commit fe24ecb

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,6 @@ jobs:
9393
tools: flex
9494
coverage: none
9595

96-
- name: Configure minimum stability
97-
if: matrix.sf_version == '7.3'
98-
run: composer config minimum-stability beta
99-
10096
- name: "Install Composer dependencies"
10197
env:
10298
SYMFONY_REQUIRE: ${{ matrix.sf_version }}

src/ProviderFactory/PluginProviderFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ final class PluginProviderFactory
2626
* @param Plugin[] $plugins
2727
* @param ProviderFactoryInterface|callable $factory
2828
* @param array<mixed, mixed> $config config to the client factory
29-
* @param array<mixed, mixed> $pluginProviderOptions config forwarded to the PluginProvider
29+
* @param array{max_restarts?: int<0, max>} $pluginProviderOptions config forwarded to the PluginProvider
3030
*/
3131
public static function createPluginProvider(array $plugins, $factory, array $config, array $pluginProviderOptions = []): PluginProvider
3232
{

tests/baseline-ignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,3 +82,4 @@
8282
%Geocoder\\Model\\Address::__construct\(\): Implicitly marking parameter \$timezone as nullable is deprecated, the explicit nullable type must be used instead%
8383
%Geocoder\\ProviderAggregator::__construct\(\): Implicitly marking parameter \$decider as nullable is deprecated, the explicit nullable type must be used instead%
8484
%Since symfony/var-exporter 7.3: The "Symfony\\Component\\VarExporter\\LazyGhostTrait" trait is deprecated, use native lazy objects instead.%
85+
%Method "Http\\Promise\\Promise::wait\(\)" might add " Resolved value, null if \$unwrap is set to false" as a native return type declaration in the future. Do the same in implementation "Geocoder\\Plugin\\Promise\\GeocoderFulfilledPromise" now to avoid errors or add an explicit @return annotation to suppress this message.%

0 commit comments

Comments
 (0)