You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, the preprocess_tonic_spikes function seems to follow a convention where shape[0] is the width of the input and shape[1] is the height, given that 2d event coordinates are provided:
This is not a bug per se, since the latter is just a preprocessing utility, but I think adhering to a consistent convention for the order of width and height would help avoiding errors down the line when building a preprocessing/training pipeline.
Edit: Overall I would prefer the convention of representing it as (height, width), as this would follow the usual matrix representation for image data.
The text was updated successfully, but these errors were encountered:
The
connect
method ofConv2D
assumes that the shape parameter of the input layer represents (height, width, channels):ml_genn/ml_genn/ml_genn/connectivity/conv_2d.py
Line 34 in 8822f90
However, the
preprocess_tonic_spikes
function seems to follow a convention whereshape[0]
is the width of the input andshape[1]
is the height, given that 2d event coordinates are provided:ml_genn/ml_genn/ml_genn/utils/data.py
Lines 99 to 100 in 8822f90
This is not a bug per se, since the latter is just a preprocessing utility, but I think adhering to a consistent convention for the order of width and height would help avoiding errors down the line when building a preprocessing/training pipeline.
Edit: Overall I would prefer the convention of representing it as (height, width), as this would follow the usual matrix representation for image data.
The text was updated successfully, but these errors were encountered: