Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression-like metrics broken for regression-like tasks #102

Open
neworderofjamie opened this issue Jun 27, 2024 · 0 comments
Open

Regression-like metrics broken for regression-like tasks #102

neworderofjamie opened this issue Jun 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@neworderofjamie
Copy link
Contributor

neworderofjamie commented Jun 27, 2024

Metrics are calculated based on the readout values e.g. https://github.com/genn-team/ml_genn/blob/master/ml_genn/ml_genn/compilers/compiled_training_network.py#L310-L316. However, for regression, the readout used to calculate the loss is "var" which, when readout at the end of the batch, only contains the value from the last timestep. This isn't even the right shape to calculate mean-squared error.

The distinction between metrics as things you observe to determine how well the model is performing vs loss functions as things that drive the learning rule is important so I think should be maintained but I fear metrics might also need some way of adding code

@neworderofjamie neworderofjamie added the bug Something isn't working label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant