printf issues

[neworderofjamie]

printf("test\n");

is pretty-printed as:

printf("test\n", );

which does not compile

[eshant742]

Hi @neworderofjamie, can you assign this issue to me? I can look into it.

[neworderofjamie]

Sure - that would be a very nice bug to fix. The problematic code is around https://github.com/genn-team/genn/blob/master/src/genn/genn/transpiler/prettyPrinter.cc#L276-L286.

[neworderofjamie]

To make iteration a bit quicker, it's probably easiest to reproduce this with a C++ example. For example if you add "printf(\"test\\n\");\n" to the end of the IzhikevichV model in https://github.com/neworderofjamie/genn_examples/blob/master/izk_regimes/model.cc#L21 and build it using genn-buildmodel.sh model.cc on Linux/MAC or genn-buildmodel model.cc on Windows you can easily reproduce this bug.

[coderpheonix]

Hi @neworderofjamie,

I hope you're doing well. I came across the issue regarding the incorrect pretty-printing of printf("test\n");, which is being displayed as printf("test\n", );. I'm interested in working on fixing this bug. Could you kindly let me know if this issue is still open or if it has already been resolved? If it's still open, I'd be happy to take a look at it.

Thanks in advance!

Best regards,
Shahidul Islam

[Sakthi-S29]

Hi @gitsofaryan, I noticed that you linked a PR (#650) for this issue, and it looks like the fix was made — but the issue is still open. I couldn't quite understand why it's still open. Was the fix incomplete, or are there CI/test failures preventing it from being merged?

I'd love to understand the current status so I can learn from it or contribute further if needed. Thanks!