Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated cert does not include domain name of params.external_domain #17

Open
thomasmitchell opened this issue Oct 31, 2019 · 2 comments

Comments

@thomasmitchell
Copy link
Contributor

If the kit generates a cert, it does not add params.external_domain as a SAN. Therefore, the kit fails to deploy if it is set to something other than the static IP of the shield box.

@jhunt
Copy link
Contributor

jhunt commented Nov 6, 2019

is params.external_domain required? If not, then (IIRC) we run into problems putting it in the kit.yml certificates schema.

@thomasmitchell
Copy link
Contributor Author

It is "required" in the sense that if the user doesn't give it, the kit provides it. But if the requirement is that it be provided by a user without the need for a spruce eval phase, then no.

dennisjbell added a commit that referenced this issue Jan 7, 2021
Completes fix for #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants