Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Align version with Engine #616

Open
daniviga opened this issue Mar 23, 2017 · 5 comments
Open

Align version with Engine #616

daniviga opened this issue Mar 23, 2017 · 5 comments

Comments

@daniviga
Copy link
Contributor

daniviga commented Mar 23, 2017

Current version of hazardlib is 0.24; in my opinion

  • It's stable enough to have a major >= 1
  • Its version should be aligned with the Engine; technically it's already like this (2.4 vs 0.24) and almost any change to hazardlib must be reflected to the engine (and vv) so it would be good to have only a version.

This will reduce a lot the confusion.

@micheles
Copy link
Contributor

LGTM

@pslh
Copy link
Member

pslh commented Mar 23, 2017

I do agree that the hazardlib is stable enough to have a version >= 1.0.

I am not sure the version of the hazardlib should be equal to that of the engine. If we make a change to the engine without changing the hazard lib do we intend to change the version number of the hazardlib without any other changes?

@daniviga
Copy link
Contributor Author

daniviga commented Mar 23, 2017

That's a good point @pslh but it never happened in 4 years. We always had versions aligned. We should consider pros and cons of both the options.

We need to take into account that "hazardlib" includes baselib, which is a fundamental part of the engine and changes to the engine often require changes to baselib. Am I wrong @micheles ?

@pslh
Copy link
Member

pslh commented Mar 23, 2017

The dependencies of hazardlib all apply to the engine but not vice-versa. If we add support for different parallel processing frameworks, I could imagine that we might well change the engine without changing the underlying libraries.

If it is really true that a new oq-engine version implies a new hazardlib version and vice-versa, perhaps we should review our decision to have them in separate repositories.

It is possible to use the hazardlib without the engine, so it should be possible to download/install the hazardlib without having to download/install the engine.

We expect code changes in hazardlib not to break the engine, so hazardlib developers already need both repositories.

@pslh pslh changed the title Allign version with Engine Align version with Engine Mar 23, 2017
@micheles
Copy link
Contributor

micheles commented Mar 23, 2017

it is really true that a new oq-engine version implies a new hazardlib version and vice-versa, perhaps we should review our decision to have them in separate repositories.*

I have been pointing out this for years. I do not remember any major version release having hazardlib changes independent from engine changes.

@micheles micheles reopened this Mar 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants