Remove automatic cloud-init option allowing PasswordAuthentication #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
|
@geerlingguy Would it be possible to merge this PR please? |
geerlingguy
reviewed
Apr 9, 2024
| lineinfile: | ||
| dest: "{{ security_ssh_cloudinit_config_path }}" | ||
| regexp: "^PasswordAuthentication" | ||
| state: absent |
There was a problem hiding this comment.
The way this is set up, it would still remove this option even if Password Auth is allowed, and it might also break on non-Ubuntu systems...
There was a problem hiding this comment.
- name: Apply same SSH configuration to Ubuntu cloud-init SSH configuration
lineinfile:
dest: "{{ security_ssh_cloud_init_config_path }}"
regexp: "^PasswordAuthentication"
line: "PasswordAuthentication {{ security_ssh_password_authentication }}"
state: present
validate: 'sshd -T -f %s'
mode: 0600
notify: restart ssh
when: ansible_distribution == 'Ubuntu'
Would that be a better approach?
There was a problem hiding this comment.
I changed the Debian.yml to
---
security_ssh_config_path: /etc/ssh/sshd_config
security_ssh_config_dir_path: /etc/ssh/sshd_config.d
security_ssh_cloud_init_config_path: "{{ security_ssh_config_dir_path }}/50-cloud-init.conf"
security_sshd_name: ssh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #117
A bug in the Ubuntu 22.04 installer generates a cloud-init config file which overwrites the
PasswordAuthenticationoption set by this Ansible role, thus ignoring any attempt to disable it. This commit ensures that line in that file doesn't exist anymore.