Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage config file #24

Closed
wants to merge 1 commit into from
Closed

Manage config file #24

wants to merge 1 commit into from

Conversation

exploide
Copy link
Contributor

Since it was really easy to implement, I fixed #23 w/o waiting for your feedback. Feel free to decline or request changes ;-)

This introduces a role variable that allows to set global options for certbot that go into /etc/letsencrypt/cli.ini.

@exploide
Copy link
Contributor Author

Ok, I don't see why the Ubuntu tests fail. On the first glance, this looks unrelated.

@oxyc
Copy link
Contributor

oxyc commented Apr 22, 2017

Yeah it's an upstream bug ansible/ansible#23530. Also geerlingguy/drupal-vm#1302.

Unfortunately I don't think the more ideal fix of {{ ansible_user|default(ansible_user_id) }} will work on Ubuntu 12.04 but maybe worth a try and see what travis says. If the variable defaulted to ansible_user_id, the docs might need to highlight even more that the user should be changed to a non-root user account, as that's the default otherwise.

@exploide
Copy link
Contributor Author

Ah, thanks for the explanation and pointing this out. Then it is in fact unrelated and further action concerning this is out of scope of this PR.

@exploide
Copy link
Contributor Author

Is there anything I can do to help getting this merged?

@oxyc
Copy link
Contributor

oxyc commented Jun 2, 2017

I believe the fix is geerlingguy/ansible-role-backup@72b9945

@exploide
Copy link
Contributor Author

Ok, I incorporated this change. Unfortunately, it seems CentOS 6 still can't find the variable.

@nkakouros
Copy link

I think this will work:

certbot_auto_renew_user: "{{ lookup('env', 'USER') }}"

@exploide
Copy link
Contributor Author

exploide commented Sep 7, 2017

Finally :D thanks @tterranigma

Hopefully it's ready to merge now @geerlingguy

@exploide
Copy link
Contributor Author

I rebased and cleaned up this PR. While this has nothing directly to do with using the staging server, it generally allows deploying the /etc/letsencrypt/cli.ini configuration file with whatever options one wants.

@geerlingguy do you want this to go in? If yes feel free to merge, but also feel free to close otherwise. Meanwhile I'm using an own role tailored to the needs of my infrastructure, so this is no longer important to me but I wanted to keep the contribution usable and I'm interested in resolving this PR.

@kzap
Copy link

kzap commented Dec 29, 2018

could this be merged @geerlingguy ?

@exploide
Copy link
Contributor Author

closed since it has conflicts and I'm no longer maintaining this PR

@exploide exploide closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide setting to use staging server
4 participants