Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-RedHat.yml #190

Closed
mprusov opened this issue Nov 28, 2022 · 7 comments · May be fixed by #199
Closed

setup-RedHat.yml #190

mprusov opened this issue Nov 28, 2022 · 7 comments · May be fixed by #199
Labels

Comments

@mprusov
Copy link

mprusov commented Nov 28, 2022

Probably the code:

  - name: Enable DNF module for CentOS 8.3+.
    shell: |
      dnf config-manager --set-enabled powertools
    register: dnf_module_enable
    changed_when: false

    when: ansible_facts['distribution_version'] is version('8.3', '>=')

  - name: Enable DNF module for CentOS 8.0–8.2.
    shell: |
      dnf config-manager --set-enabled PowerTools
    register: dnf_module_enable
    changed_when: false

when: ansible_facts['distribution_version'] is version('8.2', '<=')

should be:

  - name: Enable DNF module for CentOS 8.3+.
    shell: |
      dnf config-manager --set-enabled powertools
    register: dnf_module_enable
    changed_when: false
    when: ansible_facts['distribution_version'] is version('8.3', '>=')

  - name: Enable DNF module for CentOS 8.0–8.2.
    shell: |
      dnf config-manager --set-enabled PowerTools
    register: dnf_module_enable
    changed_when: false
    when: ansible_facts['distribution_version'] is version('8.2', '<=')

?

@csuka
Copy link

csuka commented Dec 15, 2022

Yes, I guess so too.
And your title should be, setup-RedHat.yml 👯‍♂️

@stale
Copy link

stale bot commented Mar 19, 2023

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

1 similar comment
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@stale stale bot added the stale label Jun 18, 2023
@mprusov mprusov changed the title setup-ReadHat.yml setup-RedHat.yml Jun 22, 2023
@stale
Copy link

stale bot commented Jun 22, 2023

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jun 22, 2023
@StefanIGit
Copy link

That's why I add my "when"s on top under the name ;)
Anyway, any plans to support CentOS 9?

Copy link

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Nov 13, 2023
Copy link

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants