Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with GafferPop's GetAllElements limitting on proxy stores #3209

Closed
tb06904 opened this issue May 13, 2024 · 0 comments · Fixed by #3214
Closed

Issues with GafferPop's GetAllElements limitting on proxy stores #3209

tb06904 opened this issue May 13, 2024 · 0 comments · Fixed by #3214
Assignees
@tb06904
Labels
bug Confirmed or suspected bug proxy-store Specific to/touches the proxy-store module tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.2

Comments

@tb06904
Copy link
Member

tb06904 commented May 13, 2024 •
edited

Describe the bug
This was found testing some of the standard gremlin queries but via the proxy store, there is essentially three smaller but related issues.

  • Proxy store can't accept operation chains that have unmodifiable options or null options this needs making more robust.
  • The GafferPopGraphStep doesnt actually run the right vertex() method on the graph class due to it wrapping the array in a list which pushes it to an override method.
    The apache utils method for checking the size of the returned iterator seems to have casting issues from LinkedList to Element when using proxy store this could be some deserialisation issue
@tb06904 tb06904 added bug Confirmed or suspected bug proxy-store Specific to/touches the proxy-store module tinkerpop Specific to/touches the tinkerpop module labels May 13, 2024
@tb06904 tb06904 self-assigned this May 13, 2024
@tb06904 tb06904 linked a pull request May 15, 2024 that will close this issue
Gh-3209: GetAll Limit fails on Proxy Store #3214
Merged
@github-actions github-actions bot mentioned this issue May 15, 2024
Merged
tb06904 added a commit that referenced this issue May 16, 2024
@tb06904
Merge branch 'develop' into gh-3209-getall-limit-proxy-store
20efa81
tb06904 added a commit that referenced this issue May 20, 2024
@tb06904
Merge branch 'develop' into gh-3209-getall-limit-proxy-store
935572c
GCHQDeveloper314 added a commit that referenced this issue May 22, 2024
@GCHQDeveloper314
Merge branch 'develop' into gh-3209-getall-limit-proxy-store
b57e915
tb06904 added a commit that referenced this issue May 28, 2024
@tb06904
Merge branch 'develop' into gh-3209-getall-limit-proxy-store
3bf5600
GCHQDeveloper314 pushed a commit that referenced this issue May 29, 2024
@tb06904
Gh-3209: GetAll Limit fails on Proxy Store (#3214)
c094be2 
* prevent null operation options

* fix graph step and additional opchain nesting

* add work around for deserialiser
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.3.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tb06904 tb06904

Labels
bug Confirmed or suspected bug proxy-store Specific to/touches the proxy-store module tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Gh-3209: GetAll Limit fails on Proxy Store gchq/Gaffer
2 participants
@GCHQDeveloper314 @tb06904