-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title: Refactor Library.jsx for Better Maintainability and Performance #217
Comments
I agree with this. The Library.jsx is quite large. If you would like to work on it I have some ideas and suggestions and you're welcome to make any improvements you see necessary. It does need extensive refactoring. |
@gbowne1 |
My suggested improvements for Library.jsx would be listed in one of the current PRs as a comment: Its unfinished code so the implementation needs to be completed but.. you can probably see where I was headed with that. This reduces some of the import lines by grouping them together like the @mui imports currently listed over several lines It also attempts to fix the useState imports, change some fo async functions and const arrow functions where necessary Also its attempts to fix the returned components which make the code cluttered. What ideas do you have? |
@gbowne1 |
Our code for Library.jsx is close to 900 lines. What do you think of my idea? However I am all for reuseable code and making it more maintainable My other idea was to create imported js modules to extract the many functions and states we are using We should also be looking at making use of more useState, useEffect, useRef, useMemo, useCallback, etc and others where they make sense but those are probably the most useful. |
@gbowne1 |
Ok. Well this issue is open. |
Hello,
I've been working with
Library.jsx
and observed that its large size contributes to difficulty in maintenance, readability issues, and triggers unnecessary re-renders.Suggestion:
Refactoring
Library.jsx
into smaller, component-based files could significantly enhance our codebase by improving readability, making maintenance easier, and potentially optimizing performance by reducing unnecessary re-renders.Benefits:
I believe this change could lead to more efficient development workflows and a more robust application. Looking forward to your thoughts and feedback on this proposal.
Best,
George
The text was updated successfully, but these errors were encountered: