#102 : Increase test coverage as per Sonar report

Author: gazbert

build.gradle

@@ -64,7 +64,8 @@ ext.libraries = [
         spring_boot_starter_test    : dependencies.create("org.springframework.boot:spring-boot-starter-test:" + ext.versions.springBootVersion) {
             exclude module: "spring-boot-starter-logging"
             force = true
-        }
+        },
+        awaitility                  : dependencies.create("org.awaitility:awaitility:3.1.6"),
 ]
 
 allprojects {

bxbot-core/src/main/java/com/gazbert/bxbot/core/config/exchange/AuthenticationConfigImpl.java

@@ -54,12 +54,4 @@ Map<String, String> getItems() {
   public void setItems(Map<String, String> items) {
     this.items = items;
   }
-
-  @Override
-  public String toString() {
-    return MoreObjects.toStringHelper(this)
-               // WARNING - careful showing this!
-               // .add("items", items)
-               .toString();
-  }
 }

bxbot-core/src/main/java/com/gazbert/bxbot/core/config/exchange/ExchangeConfigImpl.java

@@ -91,8 +91,7 @@ public String toString() {
     return MoreObjects.toStringHelper(this)
                .add("exchangeName", exchangeName)
                .add("exchangeAdapter", exchangeAdapter)
-               // WARNING - careful showing this!
-               //.add("authenticationConfig", authenticationConfig)
+               .add("authenticationConfig", "NOT SHOWN BY DESIGN")
                .add("networkConfig", networkConfig)
                .add("otherConfig", otherConfig)
                .toString();

pom.xml

@@ -239,6 +239,12 @@
                 <version>${spring-boot-starter.version}</version>
                 <scope>test</scope>
             </dependency>
+            <dependency>
+                <groupId>org.awaitility</groupId>
+                <artifactId>awaitility</artifactId>
+                <version>3.1.6</version>
+                <scope>test</scope>
+            </dependency>
         </dependencies>
     </dependencyManagement>
 

third_party_licenses.txt

@@ -16,3 +16,4 @@ Building & Testing
 * Gradle                    - https://gradle.org/                    - https://gradle.org/license/
 * JsonPath                  - https://github.com/jayway/JsonPath     - https://github.com/jayway/JsonPath/blob/master/LICENSE
 * spring-boot-starter-test  - http://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-testing.html
+* Awaitify