Skip to content

Commit dece79a

Browse files
committed
Change verb used in log statements for machine/node name
1 parent d7c87c9 commit dece79a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/controller/machineset.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ func (c *controller) manageReplicas(ctx context.Context, allMachines []*v1alpha1
494494
// TODO@thiyyakat: find more suitable name for function
495495
func (c *controller) isMachineCandidateForPreservation(ctx context.Context, machineSet *v1alpha1.MachineSet, machine *v1alpha1.Machine) (bool, error) {
496496
if machineutils.IsPreserveExpiryTimeSet(machine) && !machineutils.HasPreservationTimedOut(machine) {
497-
klog.V(3).Infof("Machine %s is preserved until %v, not adding to stale machines", machine.Name, machine.Status.CurrentStatus.PreserveExpiryTime)
497+
klog.V(3).Infof("Machine %q is preserved until %v, not adding to stale machines", machine.Name, machine.Status.CurrentStatus.PreserveExpiryTime)
498498
return true, nil
499499
}
500500
val, exists := machine.Annotations[machineutils.PreserveMachineAnnotationKey]
@@ -977,7 +977,7 @@ func (dc *controller) annotateMachineForAutoPreservation(ctx context.Context, m
977977
if err != nil {
978978
return nil, err
979979
}
980-
klog.V(2).Infof("Updated machine %s with auto-preserve annotation.", m.Name)
980+
klog.V(2).Infof("Updated machine %q with auto-preserved annotation.", m.Name)
981981
return updatedMachine, nil
982982

983983
}

pkg/util/provider/machinecontroller/machine.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func (c *controller) updateMachine(oldObj, newObj interface{}) {
7777
}
7878

7979
if oldMachine.Generation == newMachine.Generation {
80-
klog.V(3).Infof("Skipping other non-spec updates for machine %s", oldMachine.Name)
80+
klog.V(3).Infof("Skipping other non-spec updates for machine %q", oldMachine.Name)
8181
return
8282
}
8383

@@ -439,8 +439,8 @@ func (c *controller) updateNodeToMachine(oldObj, newObj interface{}) {
439439
}
440440
// to reconcile on change in annotations related to preservation
441441
if preserveAnnotationsChanged(oldNode.Annotations, node.Annotations) {
442-
klog.V(3).Infof("Node %s for machine %s is annotated for preservation with value %s.", node.Name, machine.Name, node.Annotations[machineutils.PreserveMachineAnnotationKey])
443-
c.enqueueMachine(machine, fmt.Sprintf("handling node UPDATE event. preserve annotations added or updated for node %q", getNodeName(machine)))
442+
klog.V(3).Infof("Node %q for machine %q is annotated for preservation with value %q.", node.Name, machine.Name, node.Annotations[machineutils.PreserveMachineAnnotationKey])
443+
c.enqueueMachine(machine, fmt.Sprintf("handling node UPDATE event. Preserve annotations added or updated for node %q", getNodeName(machine)))
444444
return
445445
}
446446
c.addNodeToMachine(newObj)

0 commit comments

Comments
 (0)