Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack: prefer server tags instead of metadata #79

Open
kayrus opened this issue Feb 17, 2020 · 2 comments
Open

OpenStack: prefer server tags instead of metadata #79

kayrus opened this issue Feb 17, 2020 · 2 comments
Labels
effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/openstack OpenStack platform/infrastructure

Comments

@kayrus
Copy link

kayrus commented Feb 17, 2020

At the moment Gardener nodes are detected by listing all the servers in the project, then the servers list is filtered at the MCM side:
https://github.com/gardener/machine-controller-manager/blob/86b72854549fa6cbe6c6a8c1c5ec727f164f07f3/pkg/driver/driver_openstack.go#L286

OpenStack Nova supports tags, and tags can be used to efficiently filter compute nodes, see https://github.com/gophercloud/gophercloud/blob/193120096e295dd6fe47e5e047e5fe1a5b231e54/openstack/compute/v2/servers/requests.go#L59..L74

Filtering by tags is more efficient and it can reduce the load on the nova API side.

cc @hardikdr @prashanth26

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 18, 2020
@prashanth26 prashanth26 added kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed lifecycle/rotten Nobody worked on this for 12 months (final aging stage) labels Aug 16, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 16, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 16, 2020
@gardener-robot gardener-robot added effort/2d Effort for issue is around 2 days and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
@himanshu-kun himanshu-kun transferred this issue from gardener/machine-controller-manager Feb 21, 2023
@himanshu-kun
Copy link
Contributor

@kon-angelo is this issue still relevant?

@kon-angelo
Copy link
Contributor

@himanshu-kun it is a bit of a complex topic because now that the worker labels are passed on as server metadata but it is a valid improvement at least for the tags that the MCM provider cares and filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/openstack OpenStack platform/infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants