Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove memory resource limits #211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove memory resource limits #211

wants to merge 2 commits into from

Conversation

plkokanov
Copy link
Collaborator

How to categorize this PR?

/area auto-scaling
/kind enhancement

What this PR does / why we need it:
This PR removes memory resource limits from the gardener-extension-shoot-rsyslog-relp-admission and charts/gardener-extension-shoot-rsyslog-relp charts in accordance to the autoscaling best practices.
Also check #118.

Which issue(s) this PR fixes:
Fixes #118

Special notes for your reviewer:

Release note:

Memory resource limits have been removed from `charts/gardener-extension-shoot-rsyslog-relp-admission/values.yaml` and `charts/gardener-extension-shoot-rsyslog-relp/values.yaml`, and therefore from the corresponding deployments.

@gardener-prow gardener-prow bot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension labels Dec 13, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
ialidzhikov
ialidzhikov approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ialidzhikov
Once this PR has been reviewed and has the lgtm label, please ask for approval from plkokanov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Dec 13, 2024

LGTM label has been added.

Git tree hash: 7dd9532827961b7ed938c6703d6254604f37163a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@Kostov6 Kostov6 Awaiting requested review from Kostov6

Assignees

@ialidzhikov ialidzhikov

Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component gardener-extension-shoot-rsyslog-relp-admission: Remove memory limit and limit scaling.
2 participants
@plkokanov @ialidzhikov