Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component gardener-extension-shoot-rsyslog-relp-admission: Remove memory limit and limit scaling. #118

Open
andrerun opened this issue Jun 6, 2024 · 2 comments · May be fixed by #211
Open

Component gardener-extension-shoot-rsyslog-relp-admission: Remove memory limit and limit scaling. #118

andrerun opened this issue Jun 6, 2024 · 2 comments · May be fixed by #211
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/3 Priority (lower number equals higher priority)

Comments

@andrerun
Copy link

andrerun commented Jun 6, 2024

How to categorize this issue?
/area control-plane
/area auto-scaling
/kind enhancement

What would you like to be added:
The gardener-extension-shoot-rsyslog-relp-admission component, running in the garden namespace in the garden runtime cluster, currently specifies a memory limit and scales that limit via VPA. We could preemptively address the known issue VPA has with that type of configuration, by removing the limit and disabling limit scaling.
Why is this needed:
Preemptively mitigates a known VPA issue.
@gardener-prow gardener-prow bot added area/control-plane Control plane related area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension labels Jun 6, 2024
@JordanJordanov JordanJordanov added the priority/3 Priority (lower number equals higher priority) label Aug 7, 2024
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all issues.
This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Mark this issue as rotten with /lifecycle rotten
  • Close this issue with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2024
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all issues.
This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close

/lifecycle rotten

@gardener-prow gardener-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 5, 2024
@plkokanov plkokanov linked a pull request Dec 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/3 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove memory resource limits plkokanov/gardener-extension-shoot-rsyslog-relp
3 participants
@JordanJordanov @gardener-ci-robot @andrerun