Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for authenticating with Amazon ECR private registry using repository policies and/or IAM policies #240

Open
m-the-magnificent opened this issue Aug 15, 2024 · 9 comments
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@m-the-magnificent
Copy link

How to categorize this issue?

/area security
/kind enhancement

What would you like to be added:
I would like the registry cache to be able to pull and cache images where

  1. the upstream registry is an Amazon ECR private registry, and,
  2. access is managed by Repository policies,
  3. without explicit credentials being used.

In this use case, the AWS account where the shoot is deployed, and the registry cache pod is running, already has pull access to the repositories in Amazon ECR private registry via repository policies.

Why is this needed:

  • We have a large number of large shoots in AWS, where services use Amazon ECR private registry as their registry to pull images from. Access to the private registry is managed via repository policies. There are no explicit credentials being used (e.g., username / password).
  • We would like to leverage the registry cache extension to cache images.
@gardener-prow gardener-prow bot added area/security Security related kind/enhancement Enhancement, improvement, extension labels Aug 15, 2024
@ialidzhikov
Copy link
Member

As we talked offline, the limitation comes from the Distribution project, see distribution/distribution#4281.

@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all issues.
This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Mark this issue as rotten with /lifecycle rotten
  • Close this issue with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2024
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all issues.
This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close

/lifecycle rotten

@gardener-prow gardener-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2024
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all issues.
This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten

/close

@gardener-prow gardener-prow bot closed this as completed Jan 16, 2025
Copy link
Contributor

gardener-prow bot commented Jan 16, 2025

@gardener-ci-robot: Closing this issue.

In response to this:

The Gardener project currently lacks enough active contributors to adequately respond to all issues.
This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ialidzhikov
Copy link
Member

/reopen

@gardener-prow gardener-prow bot reopened this Jan 16, 2025
Copy link
Contributor

gardener-prow bot commented Jan 16, 2025

@ialidzhikov: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ialidzhikov
Copy link
Member

/remove-lifecycle rotten

@gardener-prow gardener-prow bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 16, 2025
@ialidzhikov
Copy link
Member

There is now some kind of support merged in the Distribution project for exec plugins: distribution/distribution#4438

@ialidzhikov ialidzhikov added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants