Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split options for provider-env and kubectl-env #76

Open
holgerkoser opened this issue Jan 28, 2022 · 0 comments
Open

Split options for provider-env and kubectl-env #76

holgerkoser opened this issue Jan 28, 2022 · 0 comments
Assignees
@holgerkoser
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@holgerkoser
Copy link
Member

What would you like to be added:
We should create provider-env and kubectl-env separate options structs.

Why is this needed:
This will make the code much cleaner, improves stability and readability of unit tests.
@holgerkoser holgerkoser added component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension labels Jan 28, 2022
@holgerkoser holgerkoser self-assigned this Jan 28, 2022
@holgerkoser holgerkoser mentioned this issue Jan 28, 2022
Merged
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jul 28, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holgerkoser holgerkoser

Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holgerkoser @gardener-robot