Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gardenctl should not be hardcoded #118

Open
holgerkoser opened this issue Feb 22, 2022 · 1 comment
Open

gardenctl should not be hardcoded #118

holgerkoser opened this issue Feb 22, 2022 · 1 comment
Labels
component/gardenctl Gardener CLI kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@holgerkoser
Copy link
Member

What happened:
If the gardenctl binary is renamed this is not reflected in help, templates, ...

What you expected to happen:
Use os.Args[0] instead of hardcoded name gardenctl

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Environment:

@petersutter petersutter changed the title gardenctl should not hardcoded gardenctl should not be hardcoded Feb 22, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 22, 2022
@tedteng
Copy link
Contributor

tedteng commented Oct 20, 2022

a heads-up. one scenario I meet today.

If gardenctl is not hard coded and replaced by os.Args[0]. it will trigger the diff error when make gen-markdown && make test because the os.Args[0] randomly generated the main command in the markdown.

< $ eval "$(/var/folders/2v/2qyfy_h52_70zp48y_8whzdw0000gn/T/go-build1097728321/b001/exe/markdown history-env zsh)"
---
> $ eval "$(/var/folders/2v/2qyfy_h52_70zp48y_8whzdw0000gn/T/go-build3323316227/b001/exe/markdown history-env zsh)"

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/gardenctl Gardener CLI kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants