Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening cluster role RBAC to service account #251

Open
segaldor opened this issue May 15, 2022 · 1 comment
Open

Hardening cluster role RBAC to service account #251

segaldor opened this issue May 15, 2022 · 1 comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@segaldor
Copy link

What would you like to be added:
I would like external-dns-management to support namespaced roles to service account instead of cluster role permissions.

As part of the bootstrap process, this service account tries to access secrets on cluster scope.
In addition is it possible to remove "update" permission (https://github.com/gardener/external-dns-management/blob/master/charts/external-dns-management/templates/clusterrole.yaml) before implementing feature.

I would have added few more words on how would we wish things would have been, such as: we should grant permissions according to configuration (because times we'll want to grant permissions in cluster scope and times only according to ns)

Why is this needed:
Security issues - This cluster role grants permissions to access sensitive resources (controller gets permissions to secrets in cluster scope)

@segaldor segaldor added the kind/enhancement Enhancement, improvement, extension label May 15, 2022
@MartinWeindel
Copy link
Member

Currently it is not possible to remove the cluster role permissions, as the external-dns-management is designed to work on all namespaces (also ones created dynamically). Therefore it uses cluster-wide watches. Update permissions for secrets, services, and ingresses are needed to set finalizers for various purposes.

It would be needed to implement some command line option to change to the watches to a given set of namespaces. Feel free to contribute such a change.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 14, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants