Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD Validation for ETCD #989

Open
3 tasks
Shreyas-s14 opened this issue Jan 31, 2025 · 0 comments · May be fixed by #995
Open
3 tasks

CRD Validation for ETCD #989

Shreyas-s14 opened this issue Jan 31, 2025 · 0 comments · May be fixed by #995
Assignees
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension
Milestone

Comments

@Shreyas-s14
Copy link
Contributor

Shreyas-s14 commented Jan 31, 2025


How to categorize this issue?
/kind enhancement
/area quality

What would you like to be added:
Validation for the fields within the etcd resource to be done within etcd-druid. This would be done using x-validations wherein the validation rules are written using CEL expressions.

Why is this needed:
This would ensure that the validations for etcd are done within etcd-druid. By using CEL expressions, we can validate resource fields without requiring an external validating webhook. Since these CEL expressions are compiled and type checked against a CRD's schema when the CRDs are created and updated, Cluster operability improves because CRD validation no longer requires a remote call to a webhook endpoint, eliminating a potential point of failure.

Supersedes #409 . Please check #409 for history of arriving at CEL expressions as a viable solution for validation.
TODO

  • Add CRD validations
  • Add integration tests for each field being validated
  • Add documentation for the list of validations being done
@Shreyas-s14 Shreyas-s14 added the area/quality Output qualification (tests, checks, scans, automation in general, etc.) related label Jan 31, 2025
@Shreyas-s14 Shreyas-s14 self-assigned this Jan 31, 2025
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Jan 31, 2025
@shreyas-s-rao shreyas-s-rao added this to the v0.28.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants