Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring common controller config items out into interface #937

Open
shreyas-s-rao opened this issue Nov 26, 2024 · 0 comments
Open

Bring common controller config items out into interface #937

shreyas-s-rao opened this issue Nov 26, 2024 · 0 comments
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension

Comments

@shreyas-s-rao
Copy link
Contributor

How to categorize this issue?

/area quality
/kind enhancement

What would you like to be added:

Create interface for controller Config, which includes Workers and FeatureGates, and collect all CaptureFeatureActivations methods into a single method on the interface, which is called for all controllers by default.

Why is this needed:
Harmonize configurations for all the controllers, and the webhooks as well to some extent. For instance, since all controllers specify Workers in their configs, this can be brought out as a common configuration item. Similarly, FeatureGates is used by all controllers and webhooks, so that can be brought out as a common config item as well.

@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants