Fixed predicates to allow events for Etcd resource that have never been reconciled before #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind-nondistroless-etcd |
|
/test pull-etcd-druid-e2e-kind |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
anveshreddy18
approved these changes
Oct 29, 2024
renormalize
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Thanks for this PR.
We should ensure that we fix this bug even for the general use case without the external update event soon.
etcd-druid/internal/controller/utils/reconciler.go
Lines 39 to 48 in df3ff21
If the above function is invoked, we know for sure that an event is triggered for a particular etcd CR. Instead of never requeuing if that particular resource is not found, maybe we could requeue after a certain backoff period?
gardener-robot
added
the
status/closed
anveshreddy18
pushed a commit
to anveshreddy18/etcd-druid
that referenced
this pull request
Oct 29, 2024
…en (gardener#900) reconciled before (gardener#898)
unmarshall
added a commit
that referenced
this pull request
Oct 29, 2024
…en (#900) (#904) reconciled before (#898) Co-authored-by: Madhav Bhargava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reconciled before (#898)
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
For gardener use cases the predicates for the etcd reconciler have been changed to allow events for existing Etcd resources for which the original
Createevent could not be processed. Subsequent update events triggered by gardenlet reconciliation loop should be allowed to be processed.Which issue(s) this PR fixes:
Partially Fixes #898
Special notes for your reviewer:
This partially fixes #898 for gardener usage. For open source consumption (without gardener) this fix will only work if there is another component which can generate an update event. So we need to further think on how to do this properly for non-gardener use cases.
Release note: