Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster size indicator label to etcd pods #877

Open
shreyas-s-rao opened this issue Sep 11, 2024 · 2 comments
Open

Add cluster size indicator label to etcd pods #877

shreyas-s-rao opened this issue Sep 11, 2024 · 2 comments
Labels
area/ops-productivity Operator productivity related (how to improve operations) area/usability Usability related kind/enhancement Enhancement, improvement, extension

Comments

@shreyas-s-rao
Copy link
Contributor

How to categorize this issue?

/area usability ops-productivity
/kind enhancement

What would you like to be added:
Druid should add a new label to etcd pods to indicate the cluster size, or whether it's part of a single-node or multi-node cluster.

Why is this needed:
This allows for better scheduling decisions by orthogonal schedulers like kupid or kyverno. The label can be named druid.gardener.cloud/etcd-cluster-size: N for example.

@shreyas-s-rao shreyas-s-rao added this to the v0.24.0 milestone Sep 11, 2024
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) area/usability Usability related kind/enhancement Enhancement, improvement, extension labels Sep 11, 2024
@unmarshall
Copy link
Contributor

can you also add what is the gap that you have seen which causes issues when using kupid/kyverno? Also can you adjust your description as these are not really schedulers.

@ishan16696 ishan16696 modified the milestones: v0.24.0, v0.23.0 Sep 23, 2024
unmarshall added a commit to unmarshall/etcd-druid that referenced this issue Sep 30, 2024
unmarshall added a commit to unmarshall/etcd-druid that referenced this issue Oct 23, 2024
Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
Added use-etcd-wrapper cli arg for etcdbr container
unmarshall added a commit to unmarshall/etcd-druid that referenced this issue Oct 23, 2024
Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
Added use-etcd-wrapper cli arg for etcdbr container
unmarshall added a commit to unmarshall/etcd-druid that referenced this issue Oct 23, 2024
Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
Added use-etcd-wrapper cli arg for etcdbr container
shreyas-s-rao pushed a commit that referenced this issue Oct 23, 2024
…client and peer communication (#883)

* fixes #881, #877
* Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
* Added use-etcd-wrapper cli arg for etcdbr container
* removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-druid that referenced this issue Oct 23, 2024
…client and peer communication (gardener#883)

* fixes gardener#881, gardener#877
* Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
* Added use-etcd-wrapper cli arg for etcdbr container
* removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1
@shreyas-s-rao
Copy link
Contributor Author

The label was not added in #883 , as it breaks certain scheduling decisions when topology spread constraints are orthogonally added to the statefulset without going through the Etcd spec, especially during the scale-up scenario from 1 replica to 3 replicas. This is because, the single-replica pod will have cluster-size=1, while the two new pods that come up upon scale-up, will have label cluster-size=3, since pod-0 is rolled only after the two new pods come up.

@shreyas-s-rao shreyas-s-rao removed this from the v0.23.0 milestone Oct 23, 2024
shreyas-s-rao added a commit that referenced this issue Oct 23, 2024
…client and peer communication (#883) (#894)

* fixes #881, #877
* Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23
* Added use-etcd-wrapper cli arg for etcdbr container
* removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1

Co-authored-by: Madhav Bhargava <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ops-productivity Operator productivity related (how to improve operations) area/usability Usability related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

4 participants