Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ [DEP-04] Implement EtcdMember Custom Resource #702

Open
29 tasks
shreyas-s-rao opened this issue Oct 10, 2023 · 0 comments
Open
29 tasks

☂️ [DEP-04] Implement EtcdMember Custom Resource #702

shreyas-s-rao opened this issue Oct 10, 2023 · 0 comments
Assignees
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age)

Comments

@shreyas-s-rao
Copy link
Contributor

shreyas-s-rao commented Oct 10, 2023

How to categorize this issue?

/area quality robustness usability
/kind enhancement cleanup api-change task

What would you like to be added:
Implement [DEP-04] EtcdMember Custom Resource proposal.

Task List

  • Further API changes:
  • CRDs:
    • Write go structs, generate CRDs for EtcdMember
    • Update Etcd resource status
    • Update helm chart structure (add crds folder in single chart)
  • Etcd controller
    • Create/delete EtcdMember resources during reconciliation
    • Stop creating snapshot leases; delete existing snapshot leases
    • Scale-up changes:
      • Check for PeerTLSEnabled from EtcdMember instead of member lease annotation
      • Requeue reconciliation after updating peerTLS and re-check, rather than a blocking wait in the same reconciliation
      • Don't restart pods when peerTLS is enabled/disabled
      • Don't add annotation to sts for scale-up
      • Configmap changes (naming, format)
      • Adapt etcd config generation per member
    • Feature gate to enable/disable EtcdMember functionality
  • Custodian controller:
    • Update status.members by checking EtcdMember and member lease resources
    • Check etcd status.ready using pod readiness, and adapt Ready and AllMembersReady checks accordingly
    • Check BackupReady condition using EtcdMember resources instead of snapshot leases
  • Compaction controller
    • Watch EtcdMember resources, with predicate to filter on changes to status.snapshots section
    • Introduce new flag for threshold on accumulated delta snapshot size, like CompactionSnapshotSizeThreshold
    • Trigger compaction job by computing difference between status.snapshots.lastDelta.endRevision and status.snapshots.lastFull.endRevision, or checking status.snapshots.accumulatedDeltaSize
  • ☂️ Re-write etcd-backup-restore as etcd-steward, with EtcdMember updation capabilities etcd-steward#1
  • Add upgrade tests for etcd clusters
  • Add chaos tests for etcd clusters
  • Document design decisions
@shreyas-s-rao shreyas-s-rao added the kind/enhancement Enhancement, improvement, extension label Oct 10, 2023
@shreyas-s-rao shreyas-s-rao pinned this issue Oct 23, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age)
Projects
None yet
Development

No branches or pull requests

4 participants