Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Simplify etcd configuration and use proper URL instead of using @ as separator #476

Closed
Tracked by #717
unmarshall opened this issue Nov 28, 2022 · 1 comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/4 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Milestone

Comments

@unmarshall
Copy link
Contributor

Feature (What you would like to be added):

When creating configuration to be used subsequently by etcd-backup-restore and etcd containers two properties, namely:
initial-advertise-peer-urls and advertise-client-urls use @ character to separate different parts of the URL. This is not really required. Other properties which also contain URLs use proper HTTP URL format namely: initial-cluster, listen-[client/peer]-urls. Using @ only complicates the usage with no added benefit.

Motivation (Why is this needed?):
Reduce the complexity where it is not needed.

Approach/Hint to the implement solution (optional):

@unmarshall unmarshall added the kind/enhancement Enhancement, improvement, extension label Nov 28, 2022
@unmarshall unmarshall added the area/quality Output qualification (tests, checks, scans, automation in general, etc.) related label Nov 28, 2022
@abdasgupta abdasgupta added the priority/4 Priority (lower number equals higher priority) label Jan 9, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 18, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels May 27, 2024
@anveshreddy18 anveshreddy18 removed their assignment Nov 14, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.25.0 milestone Nov 26, 2024
@shreyas-s-rao
Copy link
Contributor

/close by #812

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/4 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

5 participants