Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Restoration from only delta snapshots without a full snapshot #611

Open
shreyas-s-rao opened this issue Apr 5, 2023 · 0 comments
Labels
kind/question Question (asking for help, advice, or technical detail) lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@shreyas-s-rao
Copy link
Collaborator

Question:
Is there a valid use case for etcdbr to restore from a bucket which has only delta snapshots and no full snapshots? I ask this because in a recent PR I was working on, I saw the negative test for restoring from only delta snapshots when no full snapshot is present here.

I also see here in the code that restorer does not return error when it doesn't see a full snapshot during restoration.

I would like to discuss on whether we want etcdbr to support this use case, or can we remove this and only support cases where we mandatorily have full snapshots in the bucket? Since etcdbr is the agent who pushes these backups to the bucket in the first place, and etcdbr always pushes an initial full snapshot before pushing delta snapshots, I feel this use case might not be valid.

/cc @ashwani2k @unmarshall

@shreyas-s-rao shreyas-s-rao added the kind/question Question (asking for help, advice, or technical detail) label Apr 5, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Dec 13, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Question (asking for help, advice, or technical detail) lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

2 participants