Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to Use oldObject from Events Instead of Managing shootsWithIssues Set #2231

Open
petersutter opened this issue Dec 12, 2024 · 0 comments
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension

Comments

@petersutter
Copy link
Member

What would you like to be added:

const { shootsWithIssues = new Set() } = options ?? {}

Currently, the module manually manages a shootsWithIssues set to track the unhealthy shoots. However, this can be simplified and made more efficient by leveraging the oldObject provided in the event handlers.

Using oldObject allows us to determine the previous state of the object and eliminates the need for an external tracking mechanism like shootsWithIssues.

Why is this needed:

@petersutter petersutter added component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

1 participant